Skip to content

Conversation

@Avery-Dunn
Copy link
Contributor

@Avery-Dunn Avery-Dunn commented Nov 14, 2025

MSAL Java version of the work done in AzureAD/microsoft-authentication-library-for-dotnet#5558

We are migrating from getting test config from the ID Labs API to a more Key Vault-based approach. This work was recently completed in MSAL .NET, and this PR makes similar changes in Java.

A lot of files were changed in this PR, reviews can focus on a single folder at a time since all the files in each received similar changes:

  • Files in com.microsoft.aad.msal4j/
    • Any class ending in "IT" is an integration test, and other than the removed/added tests described below they mainly just received changes to use the new helper classes
    • Any class not ending in "IT" is a helper, and these either received a few changes or were completely removed
  • Files in com.microsoft.aad.msal4j/labapi/
    • All of the new helper classes for the new system, and as long as the tests are succeeding they shouldn't need a deep review
    • They have similar names/styles and for a few Github is showing them as simply moved from another directory, but they can all be considered brand new
  • Files in infrastructure/
    • Our Selenium infrastructure for running browser-based tests, completely refactored to better follow Selenium conventions and standards
    • As with the other helper classes, as long as the tests are succeeding they shouldn't need a deep review
  • Files in labapi/
    • The old system, completely removed and replaced with the files in com.microsoft.aad.msal4j/labapi/
  • Misc. other files:

In addition to the lab migration, some test scenarios were streamlined to avoid over-testing or testing deprecated services:

  • ADFS: ADFS 2022 is now covered by tests, and older deprecated ADFS versions were removed (2019, v4)
  • National clouds: we decided this was over-tested and mostly behaves the same from an MSAL perspective, so other than a few remaining Arlington tests most of them were removed

@Avery-Dunn Avery-Dunn marked this pull request as ready for review November 24, 2025 23:49
@Avery-Dunn Avery-Dunn requested a review from a team as a code owner November 24, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants